Skip to content

fix(ng-dev): prevent arbitrary code execution via option injection#3736

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
josephperrott:fix-renovate-supply-chain-risk
Jun 5, 2026
Merged

fix(ng-dev): prevent arbitrary code execution via option injection#3736
alan-agius4 merged 1 commit into
angular:mainfrom
josephperrott:fix-renovate-supply-chain-risk

Conversation

@josephperrott
Copy link
Copy Markdown
Member

Adding --ignore-scripts to pnpm install commands in Renovate configurations to prevent arbitrary code execution from malicious lifecycle scripts during automated dependency updates.

@josephperrott josephperrott requested a review from alan-agius4 June 4, 2026 22:04
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Renovate configurations to run pnpm install with the --ignore-scripts flag during post-upgrade tasks to mitigate arbitrary code execution. The reviewer suggests a more comprehensive security approach by using pnpm's onlyBuiltDependencies configuration in package.json to secure all environments, including local development and CI, rather than just the Renovate environment.

Comment thread renovate-presets/default.json5
@alan-agius4 alan-agius4 merged commit 504f469 into angular:main Jun 5, 2026
16 checks passed
@alan-agius4
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants